This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Install / update extensions w/ component updater #4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
changed the title
bbondy
force-pushed
the
component_updater
branch
from
999cb59
to
01b3351
Compare
bbondy
force-pushed
the
component_updater
branch
5 times, most recently
from
7afdaf5
to
b61fe96
Compare
bbondy
force-pushed
the
component_updater
branch
from
b61fe96
to
6d1db95
Compare
bbondy
force-pushed
the
component_updater
branch
from
6d1db95
to
21d28f1
Compare
bbondy
force-pushed
the
component_updater
branch
from
21d28f1
to
0a91a04
Compare
Fix #4080 Fix #4081 Test Plan: - Completely retest each extension from scratch. - Try cleaning your userProfileDir/Extensions but not the session-store-1 file, things should be recoverable / normal - Try cleaning your session-store-1, things should be recoverable. - Try manually setting your session-store-1 for 1passwrod from 4.5.9.90 to 4.4.9.90 (replace all), edit `~/Library/Application\ Support/brave-development/Extensions/aomjjhallfgjeglblehebfpbcfeobpgk/4.5.9.90/manifest.json` and set the version inside the manifest to 4.4.9.90. Move the folder to a subfolder called 4.4.9.90 as well. - Start up and wait 10 minutes, it should update. Or you can run `require('electron').remote.session.defaultSession.updateClient.checkNow('aomjjhallfgjeglblehebfpbcfeobpgk')` to force the update. about:extensions should show the new version.
bbondy
force-pushed
the
component_updater
branch
from
0a91a04
to
00dc2c6
Compare
|
BrianJ reviewed |
This was referenced Sep 27, 2016
This was referenced Sep 29, 2016
This was referenced Oct 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
brave/muon#59
brave/libchromiumcontent#4
brave/brightray#1
brave/vault-updater#33
Fix #4080
Fix #4081
Test Plan:
~/Library/Application\ Support/brave-development/Extensions/aomjjhallfgjeglblehebfpbcfeobpgk/4.5.9.90/manifest.jsonand set the version inside the manifest to 4.4.9.90. Move the folder to a subfolder called 4.4.9.90 as well.require('electron').remote.session.defaultSession.updateClient.checkNow('aomjjhallfgjeglblehebfpbcfeobpgk')to force the update. about:extensions should show the new version.Auditors: @bridiver, @darkdh