Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add confirmation dialog after successful import of data from other browser #4190

Merged
merged 1 commit into from
Sep 22, 2016
Merged

add confirmation dialog after successful import of data from other browser #4190

merged 1 commit into from
Sep 22, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 22, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4188

requires brave/muon@58efa3c

Auditors: @bbondy

Test Plan:
dialog should show up after importing

@darkdh
add confirmation dialog after successful import of data from other br…
87c099a 
…owser

fix brave#4188

requires brave/muon@58efa3c

Auditors: @bbondy

Test Plan:
dialog should show up after importing
@bbondy
Copy link
Member

bbondy commented Sep 22, 2016

++

@bbondy bbondy merged commit 71f4ebe into brave:master Sep 22, 2016
@luixxiul luixxiul added this to the 0.12.2dev milestone Sep 23, 2016
@luixxiul luixxiul mentioned this pull request Sep 25, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/importer QA/checked-Win32
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging this pull request may close these issues.

add confirmation dialog after successful import of data from other browser
3 participants
@darkdh @bbondy @luixxiul