Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add default lastAccessTime for history entries only #5349

Merged
merged 1 commit into from
Nov 2, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 2, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Also add creationTime field for future use

fix #5183

Auditors: @bsclifton, @bbondy

Test Plan:

  1. Import bookmarks
  2. They should not appear in about:history until you visit them

2. Add creationTime field

fix brave#5183

Auditors: @bsclifton, @bbondy

Test Plan:
1. Import bookmarks
2. They should not appear in about:history until you visit them
@bbondy
Copy link
Member

bbondy commented Nov 2, 2016

++

@bbondy bbondy merged commit a409394 into brave:master Nov 2, 2016
@bsclifton
Copy link
Member

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imported bookmarks should set creationTime field (not lastAccessedTime)
5 participants