This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix drag and drop for about:newtab (and other fixes) #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove duplicates from pinned sites before binding to state - Prevent unnecessary state updates (frame.js => newtab.js and while dragging) - handle null sites array (default to new list) - updated the unique detecting logic for newVisitedSites
Fixes #5336 Auditors: @bsclifton Test Plan: * Copy/paste this file to session-store-1: https://raw.githubusercontent.com/cezaraugusto/brave-json/master/newtab-3-rows.json * Check that now we have 18 tiles on our grid * Randomly drag tiles and check that it can be dropped on any position * Open a new new tab and ensure items keep their previous indexes
This was referenced Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix drag-n-drop for topSites grid
Fixes #5336
Also includes optimizations / small bug fixes:
Auditors: @cezaraugusto @bbondy