Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reposition Brave Lion on Windows #5485

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Reposition Brave Lion on Windows #5485

merged 1 commit into from
Nov 8, 2016

Commits on Nov 8, 2016

  1. Reposition Brave Lion on Windows

    Fixes #5069 (Refine the Brave button (look, positioning, feel) on Windows)
    Fixes #5383 (Brave Logo Slides Beneath URL Bar)
    
    Also includes (no issue):
    Hide extra drag area when menu is showing
    
    Auditors: @jonathansampson, @bbondy
    
    Test Plan (required for Windows 10 and Windows 7)
    1. Launch Brave
    2. Have menu hidden and always show URL bar to true
    3. Lion should have an extra separator next to the right of it and caption
    buttons should be center aligned. Compare against mockup.
    4. Make window really skinny (width-wise)
    5. Brave lion or extension icons should NOT go under URL bar
    6. Disable "auto-hide menu" so that menu is always showing
    7. Lion should now be under the caption buttons and there should be no
    grab area to the left of it (except for where the noscript icon goes, but
    that wasn't changed and isn't draggable)
    bsclifton committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    4b2dbe0 View commit details
    Browse the repository at this point in the history