Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix findbar background on sites with a translucent theme color #5743

Merged
merged 2 commits into from
Nov 20, 2016

Conversation

josiah-keller
Copy link
Contributor

@josiah-keller josiah-keller commented Nov 20, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  • Go to a site with an rgba theme color (such as https://stackoverflow.com)
  • Press Ctrl-F
  • Note that "Match case" label and close button blend seamlessly into the rest of the findbar

Fixes #5742, #5744

@josiah-keller josiah-keller changed the title Remove background from label and close button Fix findbar background on sites with a translucent theme color Nov 20, 2016
@bradleyrichter bradleyrichter merged commit 33cbd18 into brave:master Nov 20, 2016
@luixxiul luixxiul added this to the 0.12.11 milestone Dec 7, 2016
@luixxiul luixxiul mentioned this pull request Jan 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Findbar "Match case" label and close button background
4 participants