Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor about:preferences#payments #6009

Merged
merged 3 commits into from
Dec 6, 2016
Merged

Refactor about:preferences#payments #6009

merged 3 commits into from
Dec 6, 2016

Commits on Dec 6, 2016

  1. Refactor about:preferences#payments (part 1) 

    1. Refactored about:preferences#payments (titleBar and walletBar)
  - Partly addresses #5494
2. Applied vertical-top to the right element
  - Fixes #5962
3. Refactored dialog on about:preferences#payments (l10n)
  - Closes #6007
4. Refactored Brave wallet modal dialog (part 1)
  - Fixes #5785 based on https://github.com/luixxiul/browser-laptop/commit/2327e9eca53eb4a637dd4c3e3a2a1d1f613c2fbc
5. Replaced the button on the modal dialog with the SVG icon

Auditors: @bradleyrichter @bsclifton

Test Plan 1:
1. Make sure paymentsMessage and walletBar appears at the same place by toggling the switch off/on
2. Set the toggle to on
3. Make sure every button in titleBar and walletBar works
4. Make sure height of the fund select box and account balance box is equal
5. Make sure the loading message and the question mark is aligned center
6. Make sure no button label is wrapped

Test Plan 2: make sure the row of the ledger table on about:payments is aligned horizontally

Test Plan 3:
1. Disable Coinbase via VPN
2. Make sure every button on the dialog on about:preferences#payments works

Test Plan 4:
1. Disable Coinbase via VPN
2. Make sure the grey footer no longer appears on the Add funds dialog

Test Plan 5:
1. Make sure the top right button on the modal dialog works
    Suguru Hirahara committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    21ece29 View commit details
    Browse the repository at this point in the history

  2. Fix broken tests (selector related) 

    Fixes #5951
(was broke with 46ee335)

Auditors: @luixxiul

Test Plan:
1. Window 1: run `npm run watch-all`
2. Window 2: run `npm run uitest -- --grep="Payment Panel"
3. Watch tests pass
    @bsclifton
    bsclifton authored and Suguru Hirahara committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    9bdb37a View commit details
    Browse the repository at this point in the history

  3. Replaced ids with className (for more consistency) 

    Auditors: @bsclifton

Test Plan: make sure styling of about:payments is not broken and tests pass
    Suguru Hirahara committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    95c6ddc View commit details
    Browse the repository at this point in the history