Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add focus ring to about page form elements #6037

Merged
merged 1 commit into from
Jan 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/renderer/components/bookmarksToolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class BookmarkToolbarButton extends ImmutableComponent {
: siteDetailLocation
}

return <span
return <button
className={cx({
bookmarkToolbarButton: true,
draggingOverLeft: this.isDraggingOverLeft && !this.isExpanded,
Expand Down Expand Up @@ -217,7 +217,7 @@ class BookmarkToolbarButton extends ImmutableComponent {
? <span className='bookmarkFolderChevron fa fa-chevron-down' />
: null
}
</span>
</button>
}
}

Expand Down
6 changes: 6 additions & 0 deletions less/bookmarksToolbar.less
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@
box-shadow: 0px 1px 5px 0px rgba(0, 0, 0, 0.1);
}

&:focus {
outline-color: rgb(59, 153, 252);
outline-style: auto;
outline-width: 5px;
}

&.draggingOverLeft {
&:not(.isDragging) {
margin-left: 25px;
Expand Down
1 change: 0 additions & 1 deletion less/button.less
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

button[class*="Button"] {
background: none;
outline: none;
border: none;
margin: 0;
white-space: nowrap;
Expand Down
1 change: 0 additions & 1 deletion less/forms.less
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ select {
color: @darkGray;
font-size: 14.5px;
height: 2.25em;
outline: none;
padding: 0.4em;
width: 100%;
}
Expand Down
5 changes: 5 additions & 0 deletions less/navigationBar.less
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,11 @@
}
}

.navbutton,
.navigationButton {
outline: none;
}

.navigationButton {
background-color: @buttonColor;
display: inline-block;
Expand Down