-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
Some details should be added on README.md. |
Please don't forget the hamburger (now kabob) menu links. A spec is in progress for the new help actions, but this is a good stopgap. Thanks for getting it started! |
@alexwykoff then you would have the two items in the same submenu which are linked to the same page, which is not expected? In this case either of it should be removed. |
You could deep link to the appropriate threads in community, but yes, I did suggest double-linking because it is a stopgap, not a full solution. |
@@ -10,7 +10,8 @@ const Immutable = require('immutable') | |||
const locale = require('../../js/l10n') | |||
const settings = require('../../js/constants/settings') | |||
const getSetting = require('../../js/settings').getSetting | |||
const issuesUrl = 'https://github.com/brave/browser-laptop/issues' | |||
// const issuesUrl = 'https://github.com/brave/browser-laptop/issues' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest just deleting this; comments usually just end up cluttering and we can always look at the previous revision 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
@bsclifton would you please add information about the community on README.md which sounds natural to native speakers? |
Note: |
- Added the link to the community on README - Replaced the link to GitHub issues page with "community.brave.com" - Removed issuesUrl - Removed APP_SUBMIT_FEEDBACK - data-l10n-id in preferences.properties was replaced from 'sendUsFeedback' to 'submitFeedback', which has been existed in menu.properties TODO: 'reportAnIssue' and 'submitFeedback' will be merged later Auditors: @bsclifton, @alexwykoff Test Plan: 1. Make sure the anchor link to the community (Discourse) on README works 2. Make sure each of these links opens the community in a new tab - "Submit Feedback..." in Help on the menu bar - "Report an issue" in Help on the menu bar - "Submit Feedback..." in Help on the hamburger menu - "Report an issue" in Help on the hamburger menu - "Submit Feedback..." on about:preferences
lgtm! |
Added an issue for it here: |
@bbondy thanks for doing that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ 😄
git rebase -i
to squash commits (if needed).Auditors: @bsclifton, @alexwykoff
Test Plan: