This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Test syncing history and site settings #7136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and clearing them should prevent syncing.
diracdeltas
reviewed
Feb 9, 2017
| return val.value.settings['sync.enabled'] === true | ||
| }) | ||
| }) | ||
| .pause(1000) // XXX: Wait for sync init (request AWS credentials from server) |
There was a problem hiding this comment.
does it work to replace this with waitUntil sync.lastFetchTimestamp is > 0?
There was a problem hiding this comment.
it didn't work, but maybe i can try a little more
diracdeltas
approved these changes
Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also test that clearing history and siteSettings prevents syncing.
Test Plan:
yarn test -- --grep="'^Syncing'"