Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

shifted a smidge of logic lower per suggestion by jonathansampson #7437

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

alexwykoff
Copy link
Contributor

@alexwykoff alexwykoff commented Mar 2, 2017

Auditors: @bsclifton @jonathansampson
Fix #7436

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

On macOS, Windows, and Linux

  • Enable Pocket
  • Check the urlbar

Worth checking with high DPI and lower DPI settings (to get the different icons)

@bsclifton
Copy link
Member

could you rebase -i (and reword) and use the keywords like "Fixes #7436" in the commit message itself? 😄

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the commit message comment (which we can ignore, you can always close the issue manually), looks good! 😄

shifted a smidge of logic lower per suggestion by jonathansampson

Auditors: @bsclifton @jonathansampson
@alexwykoff
Copy link
Contributor Author

Would git commit --amend work in this scenario?

@bsclifton
Copy link
Member

@alexwykoff saw you got it squared away, but yup- that would work too 😄

@bsclifton bsclifton added this to the 0.13.5 milestone Mar 2, 2017
@bsclifton bsclifton merged commit 84129f8 into master Mar 2, 2017
@bsclifton bsclifton deleted the fix_pocket_icon branch March 2, 2017 05:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants