Delete genericForm and commonDialog from forms.less #8155

luixxiul · 2017-04-09T18:46:40Z

Closes #8010
Addresses #7989

Auditors:

Test Plan: n/a

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).

Closes #8010 Addresses #7989 Auditors: Test Plan: n/a

luixxiul · 2017-04-21T08:56:44Z

Every PR which has blocked this PR was merged to refactoring-aphrodite, so it should be OK to merge this.

NejcZdovc · 2017-04-21T09:17:33Z

@luixxiul should we still merge this into refactoring-aphrodite or should we merge it into master already?

luixxiul · 2017-04-21T09:33:38Z

It should be merged to refactoring-aphrodite yet. Later I will push the final PR to master.

NejcZdovc · 2017-04-21T09:41:21Z

Ok, let's merge this one

luixxiul added PR/blocked refactoring labels Apr 9, 2017

luixxiul self-assigned this Apr 9, 2017

luixxiul added this to the 0.14.3 milestone Apr 10, 2017

luixxiul changed the title ~~Delete genericForm from forms.less~~ Delete genericForm and commonDialog from forms.less Apr 10, 2017

cezaraugusto added the PR/needs-rebase ۞ label Apr 17, 2017

luixxiul added PR/work-in-progress ⚒ PR/needs-QA-attention ☕ and removed PR/needs-rebase ۞ PR/blocked PR/work-in-progress ⚒ labels Apr 18, 2017

Remove .genericForm and .commonDialog from forms.less

b3b95a6

Closes #8010 Addresses #7989 Auditors: Test Plan: n/a

NejcZdovc merged commit c84fd1c into brave:refactoring-aphrodite Apr 21, 2017

luixxiul removed the PR/needs-QA-attention ☕ label Apr 21, 2017

luixxiul mentioned this pull request Apr 23, 2017

Refactor components with commonForm #8443

Merged

4 tasks

luixxiul deleted the delete-genericForm branch April 25, 2017 03:24

Provide feedback