Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor of tabs related components (redux component) #8396

Merged
merged 4 commits into from
Jun 2, 2017
Merged

Refactor of tabs related components (redux component) #8396

merged 4 commits into from
Jun 2, 2017

Commits on Jun 2, 2017

  1. Converts Tabs related components into redux 

    Resolves brave#8690
    @NejcZdovc @bsclifton
    NejcZdovc authored and bsclifton committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    0eac011 View commit details
    Browse the repository at this point in the history

  2. Moves functions into tabContentState

    @NejcZdovc @bsclifton
    NejcZdovc authored and bsclifton committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    e53359c View commit details
    Browse the repository at this point in the history

  3. Ref fixes

    @NejcZdovc @bsclifton
    NejcZdovc authored and bsclifton committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    f4f9b70 View commit details
    Browse the repository at this point in the history

  4. Added more tests for tabContentState and found/fixed issues along the… 

    … way:

- iconSize was not being exported correctly (it always had undefined). I moved to config and verified it has a value now
- the tab size methods now handle null/undefined properly
- updated tabContentState to use the braveExtensionId constant

Auditors: @NejcZdovc
    @bsclifton
    bsclifton committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    8c5e361 View commit details
    Browse the repository at this point in the history