Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Increase urlbar fontsize #8400

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Increase urlbar fontsize #8400

merged 2 commits into from
Apr 20, 2017

Conversation

cezaraugusto
Copy link
Contributor

Test Plan:

  • While this font size is pre-approved by @bradleyrichter, it's worth checking urlbar icons (list, lock, unlock and search) that must be aligned with new font size.

Tagging @bsclifton for review on Windows

Screenshots (macOS):

screen shot 2017-04-19 at 12 41 01 am

screen shot 2017-04-19 at 12 41 17 am

screen shot 2017-04-19 at 12 40 36 am

screen shot 2017-04-19 at 12 40 52 am

@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. labels Apr 19, 2017
@cezaraugusto cezaraugusto added this to the 0.15.1 milestone Apr 19, 2017
@cezaraugusto cezaraugusto self-assigned this Apr 19, 2017
@bsclifton
Copy link
Member

Looks good at 100%
screen shot 2017-04-19 at 2 31 47 pm

@bsclifton
Copy link
Member

Looks good at 125% too 😄
screen shot 2017-04-19 at 6 27 37 pm

bsclifton
bsclifton approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member

@bradleyrichter Windows pictures shared above ^^

@bradleyrichter
Copy link
Contributor

@bsclifton the tabs look fine but how about the URL bar? ; )

@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Apr 20, 2017 •
edited
Loading

btw also tested on Ubuntu, works the same as macOS. Windows ok on VM

@bsclifton
Copy link
Member

@bradleyrichter LOL 🤦‍♂️

I think of @cezaraugusto as the King of Tabs and subconsciously thought this PR was tweaking tab fonts. Re-checking on Windows now...

bsclifton
bsclifton suggested changes Apr 20, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a problem with the border here. This was tested at 125% DPI
screen shot 2017-04-19 at 10 58 19 pm

@cezaraugusto
Copy link
Contributor Author

sorry line-height issue, reduced to 1.4 :)

bsclifton
bsclifton approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 😄 ++
screen shot 2017-04-20 at 12 46 43 am

@cezaraugusto cezaraugusto merged commit abec1aa into master Apr 20, 2017
@cezaraugusto cezaraugusto deleted the accessibility/7848 branch April 20, 2017 07:51
@bradleyrichter bradleyrichter mentioned this pull request Apr 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bradleyrichter bradleyrichter Awaiting requested review from bradleyrichter

Assignees

@cezaraugusto cezaraugusto

Labels
design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging this pull request may close these issues.
4 participants
@cezaraugusto @bsclifton @bradleyrichter @luixxiul