Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix PDF loading local files #8644

Closed
wants to merge 1 commit into from
Closed

fix PDF loading local files #8644

wants to merge 1 commit into from

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 3, 2017

muon changes are needed in order to allow extensions to access local files. in the meantime, we can workaround this for pdfjs by copying local pdf files to a disk location to chrome-extension://.

fix #2714
requires brave/pdf.js@6b3081e

test plan:

  1. git clone https://github.com/brave/pdf.js and run 'gulp chromium'
  2. copy 'build/chromium' to '~/Library/Application\ Support/brave-development/Extensions/jdbefljfgobbmcidnmpjamcbhnbphjnb/1.8.251' or whatever your corrresponding userData directory is
  3. start Brave with PDFJS enabled and browse to a local PDF file. it should display correctly and the url in the urlbar should be the file: url.
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

fix #2714
requires brave/pdf.js@6b3081e

test plan:
1. git clone https://github.com/brave/pdf.js and run 'gulp chromium'
2. copy 'build/chromium' to '~/Library/Application\ Support/brave-development/Extensions/jdbefljfgobbmcidnmpjamcbhnbphjnb/1.8.251' or whatever your corrresponding userData directory is
3. start Brave with PDFJS enabled and browse to a local PDF file. it should display correctly.
@diracdeltas diracdeltas added this to the 0.15.2 milestone May 3, 2017
@diracdeltas diracdeltas self-assigned this May 3, 2017
@diracdeltas diracdeltas requested a review from bbondy May 3, 2017 00:36
@diracdeltas
Copy link
Member Author

found a much easier way, i'm going to close this

@diracdeltas diracdeltas closed this May 3, 2017
@luixxiul luixxiul deleted the fix/local-pdf branch May 3, 2017 01:21
@luixxiul luixxiul removed this from the 0.15.300 milestone May 20, 2017
@luixxiul luixxiul removed the request for review from bbondy May 20, 2017 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdfjs needs local file access
2 participants