This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactors Navigator and BrowserAction into redux components #8658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
NejcZdovc
force-pushed
the
redux/navigator
branch
7 times, most recently
from
f31e097
to
16cf8db
Compare
|
note: tests are still WIP, but other can be reviewed |
|
unit tests fixed 🎉 |
bridiver
reviewed
May 5, 2017
| if (activeTab && activeTab.get(navCheckProp)) { | ||
| appActions.tabCloned(activeTabId, { | ||
| if (e && eventUtil.isForSecondaryAction(e) && this.props.isNavigable) { | ||
| if (this.props.get(navCheckProp)) { |
There was a problem hiding this comment.
shouldn't this be this.props[navCheckProp]? Is there a test that covers this because I think this would cause an exception
There was a problem hiding this comment.
You are correct. Fixed.
bridiver
reviewed
May 5, 2017
| @@ -25,7 +25,10 @@ class ReduxComponent extends ImmutableComponent { | |||
| } | |||
|
|
|||
| checkForUpdates () { | |||
| if (!this.dontCheck && this.shouldComponentUpdate(this.props, this.buildProps())) { | |||
| // TODO @bridiver only temp solution | |||
There was a problem hiding this comment.
shouldn't this be @NejcZdovc instead of @bridiver?
There was a problem hiding this comment.
removed, so its fine 😄
NejcZdovc
force-pushed
the
redux/navigator
branch
2 times, most recently
from
31334fe
to
825ce57
Compare
|
I have one more failing unit test that I just added. Don't merge yet |
Resovles brave#8651 Auditors: @bsclifton @bridiver Test Plan: - test if navigation buttons are working correctly - test if extension icon are displayed correctly and text is working for them
|
Unit test fixed, thanks @bsclifton. Let's wait for travis and then merge it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Resolves #8651
Auditors: @bsclifton @bridiver
Test Plan: