This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Saving a document doesn't show correct origin #8786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
reviewed
May 10, 2017
| @@ -73,6 +73,8 @@ class DownloadItem extends ImmutableComponent { | |||
| } | |||
| render () { | |||
| const origin = getOrigin(this.props.download.get('url')) | |||
| const localFileOrigins = ['file:', 'blob:', 'data:', 'chrome-extension:', 'chrome:'] | |||
| const localFile = localFileOrigins.some((localFileOrigin) => origin.startsWith(localFileOrigin)) | |||
There was a problem hiding this comment.
this should check that origin is not null
There was a problem hiding this comment.
Did you mean like this: origin && localFileOrigins.some((localFileOrigin) => origin.startsWith(localFileOrigin)) @diracdeltas
NejcZdovc
reviewed
May 10, 2017
| @@ -160,7 +162,7 @@ class DownloadItem extends ImmutableComponent { | |||
| ? <span className='fa fa-unlock isInsecure' /> | |||
| : null | |||
| } | |||
| <span title={origin}>{origin}</span> | |||
| <span title={origin}>{localFile ? 'Local file' : origin}</span> | |||
There was a problem hiding this comment.
Please add translation here
| }) | ||
| }) | ||
|
|
||
| Object.values(downloadStates).forEach(function (state) { |
There was a problem hiding this comment.
I think that you could do this tests insider previous forEach
kumarrishav
force-pushed
the
correctOrigin
branch
from
c2de975
to
277074e
Compare
|
@diracdeltas @NejcZdovc review? |
diracdeltas
approved these changes
May 10, 2017
NejcZdovc
approved these changes
May 10, 2017
|
@kumarrishav great job on this 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix #8698
Test Plan:
Open browser
Download file having orgin file:/// or chrome-extension: or other local origin.
It should show text 'Local file' for local origin file/