fix flash always-deny setting

[diracdeltas]

fix #8826

Test Plan:

1. enable flash
2. go to http://homestarrunner.com/
3. you should see a Flash notification bar. click 'remember this decision' and 'deny'
4. close the tab and open http://homestarrunner.com/ in a new tab
5. you should not see a Flash notification bar this time

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run indivually or as a suite ref

[mrose17]

@diracdeltas & @bsclifton - i am pretty sure than whenever someone answers "No" to an "Allow to " and selects "Remember this decision", then it is never remembered regardless of . i don't think it is limited to flash, e.g., i have seen the same behavior for things like autoplay audio/video/etc.

[diracdeltas]

autoplay has a different code path so it should be a separate issue

[mrose17]

grumble.

[darkdh]

@mrose17 , you can try whole new autoplay for next version because #8848 just merged.

Allow -> Allow until tab closed
Allow and remember -> Allow until you delete the site setting in about:preferences#security
Deny -> keep blocking and won't bother you until refresh
Deny and remember -> keep blocking and won't bother you until you delete the site setting in about:preferences#security

[mrose17]

@DARdk - many thanks. i'll check the next RC!

[luixxiul]

Test plan works.

[diracdeltas]

@mrose17 it appears you edited #8826 instead of opening a new issue. FWIW because this PR fixes the original issue (flash only), your issue will be closed automatically when it is merged. If you have a separate issue, please open a separate ticket with specific repro steps.

for code organization reasons, I don't want to fix the broader issue and the flash-only issue in the same PR.

[srirambv]

@diracdeltas Is this expected?

Shouldn't it not allow to run flash after Deny is selected?

[srirambv]

Right click on the same tab where the notification was cancelled allows the flash component to run

[diracdeltas]

Shouldn't it not allow to run flash after Deny is selected?

Nope, because 'Allow Once' in the screenshot overrides the first Deny setting.

[mrose17]

@srirambv & @diracdeltas - i can't parse

Shouldn't it not allow to run flash after Deny is selected?

because of the double-negative. can the question be stated more simply? thanks!

[diracdeltas]

@mrose17 i think sriram was asking if the behavior in the screenshot is correct and i already answered

[mrose17]

@diracdeltas - thanks!