This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes pause/resume for download items #9246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves brave#9244 Auditors: @bsclifton Test Plan: - covered with test plan - try to download a file and then pause/resume i
|
@bsclifton this is also in the current release version, so if you think that we should put this in 0.17 please update milestone |
8 tasks
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Jun 6, 2017
Resolves brave#9260 Auditors: @bsclifton Test Plan: - download an item - check if download item is shown - check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Jun 6, 2017
Resolves brave#9260 Auditors: @bsclifton Test Plan: - download an item - check if download item is shown - check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
bsclifton
approved these changes
Jun 6, 2017
bsclifton
added a commit
that referenced
this pull request
Jun 6, 2017
Fixes pause/resume for download items
bsclifton
added a commit
that referenced
this pull request
Jun 6, 2017
Fixes pause/resume for download items
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Jun 6, 2017
Resolves brave#9260 Auditors: @bsclifton Test Plan: - download an item - check if download item is shown - check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Jun 6, 2017
Resolves brave#9260 Auditors: @bsclifton Test Plan: - download an item - check if download item is shown - check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Jun 6, 2017
Resolves brave#9260 Auditors: @bsclifton Test Plan: - download an item - check if download item is shown - check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #9244
Auditors: @bsclifton
Test Plan:
Reviewer Checklist:
Tests