Converts PopupWindow into redux #9417

NejcZdovc · 2017-06-13T07:14:53Z

Test Plan:

enable last pass
click on icon
window should be positioned correctly (top right) and login form of last pass should be displayed

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.

Resolves #9416

Reviewer Checklist:

Adequate test coverage exists to prevent regressions
Tests should be independent and work correctly when run individually or as a suite ref
New files have MPL2 license header

@bsclifton

Resolves brave#9416 Auditors: @bsclifton @bridiver Test Plan:

NejcZdovc added PR/work-in-progress ⚒ refactoring/redux-component labels Jun 13, 2017

NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 13, 2017

NejcZdovc self-assigned this Jun 13, 2017

NejcZdovc force-pushed the redux/popupWindow branch from 8f0f178 to 95091f6 Compare June 13, 2017 12:53

NejcZdovc removed the PR/work-in-progress ⚒ label Jun 13, 2017

NejcZdovc requested review from bridiver, bsclifton and jonathansampson June 13, 2017 12:55

Converts PopupWindow into redux

82f6afa

Resolves brave#9416 Auditors: @bsclifton @bridiver Test Plan:

NejcZdovc force-pushed the redux/popupWindow branch from 95091f6 to 82f6afa Compare June 13, 2017 15:44

This was referenced Jun 14, 2017

Redux component - Popup window #9416

Closed

Redux refactoring tracking issue #8528

Closed

bsclifton added QA/test-plan-specified release-notes/exclude labels Jun 14, 2017

bridiver approved these changes Jun 19, 2017

View reviewed changes

bridiver merged commit 142808a into brave:master Jun 19, 2017