This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
use shared memory for initial state transfer #9989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
suggested changes
Jul 14, 2017
js/stores/appStore.js
Outdated
| { | ||
|
|
||
| let state = appState.toJS() | ||
| delete state.menu |
There was a problem hiding this comment.
This won't work because Windows requires it when rendering the custom menubar (in the renderer process). I'll look at submitting a PR which avoids setting it on macOS / Linux and properly sets it (ex: doesn't bind raw object with functions) on Windows
bridiver
force-pushed
the
shared-mem-app-state
branch
from
6cb9843
to
e009588
Compare
|
@bsclifton @bbondy I removed the |
|
I submitted #9991 with the fixes for the menu. Does that need to land first? |
|
Yes, this PR will break state transfer without a fix for the menu
… On Jul 15, 2017, at 11:52 PM, Brian Clifton ***@***.***> wrote:
I submitted #9991 with the fixes for the menu. Does that need to land first?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@bridiver please post an issue for this pull requests since release notes are made from issues, and reference this issue from the PR. Thanks! |
|
Looks good but blocked on Clifton's PR I think. |
bbondy
approved these changes
Jul 17, 2017
bbondy
approved these changes
Jul 17, 2017
bbondy
added a commit
that referenced
this pull request
Jul 17, 2017
use shared memory for initial state transfer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
Fix #10018
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests