Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Replacing end of flow learn more link with Brave article #101

Merged
merged 1 commit into from
Jan 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions brave/gulpfile.js/brave-replace-paths.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,29 @@
const gulp = require('gulp')
const replace = require('gulp-replace')

/*
* This task allows us to avoid unecessary large component
* overrides when a simple href attribute just needs to be replaced
*/
const createBraveReplaceLinksTask = () => {
gulp.task('replace-brave-links', function () {
return gulp.src(['ui/app/**/*'])
.pipe(
replace(
/https:\/\/metamask\.zendesk\.com\/hc\/en-us\/articles\/360015489591-Basic-Safety-Tips/gm,
'https://support.brave.com/hc/en-us/articles/360034535452-How-can-I-add-my-other-Crypto-Wallets-to-Brave-'
)
)
.pipe(
replace(
/https:\/\/metamask\.zendesk\.com\/hc\/en-us\/articles\/360015289932/gm,
'https://support.brave.com/hc/en-us/articles/360035488071-How-do-I-manage-my-Crypto-Wallets-'
)
)
.pipe(gulp.dest(file => file.base))
})
}

const createBraveReplacePathsTask = () => {
const overrideDirs = [
'ui/app/**/*',
Expand Down Expand Up @@ -202,14 +225,8 @@ const createBraveReplacePathsTask = () => {
`'${bravePrefix}app/scripts/controllers/threebox'`
)
)
.pipe(
replace(
/'(.*)\/confirm-remove-account\.component'/gm,
`'${bravePrefix}ui/app/components/app/modals/confirm-remove-account/confirm-remove-account.component'`
)
)
.pipe(gulp.dest(file => file.base))
})
}

module.exports = createBraveReplacePathsTask
module.exports = { createBraveReplaceLinksTask, createBraveReplacePathsTask }
5 changes: 4 additions & 1 deletion brave/gulpfile.js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const createBraveManifestTask = require('./brave-manifest')
const createBravePublishTask = require('./brave-publish')
const createBraveLocalesTask = require('./brave-locales')
const createBraveHTMLTask = require('./brave-html')
const createBraveReplacePathsTask = require('./brave-replace-paths')
const {createBraveReplaceLinksTask, createBraveReplacePathsTask} = require('./brave-replace-paths')
const createBraveLoadStylesTasks = require('./brave-load-styles')
require('../../gulpfile.js')

Expand Down Expand Up @@ -34,6 +34,7 @@ copyTask('dev:copy:fonts:brave', {
})

createBraveManifestTask()
createBraveReplaceLinksTask()
createBraveReplacePathsTask()
createBraveLocalesTask()
createBraveHTMLTask()
Expand Down Expand Up @@ -67,6 +68,7 @@ gulp.task('build',
gulp.series(
'clean',
'load-brave-styles',
'replace-brave-links',
'replace-brave-paths',
'build:scss',
gulpParallel(
Expand All @@ -87,6 +89,7 @@ gulp.task('dist',
gulp.task('dev:extension',
gulp.series(
'dev:load-brave-styles',
'replace-brave-links',
'replace-brave-paths',
'clean',
'dev:scss',
Expand Down

This file was deleted.