This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Fixing login issues after partial onboarding #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
changed the title
bbondy
approved these changes
Feb 4, 2020
Hi, Not sure if this has been fixed @ryanml . I am still having this same issue. |
|
Hey @btommm - this update actually has not been released to the browser, we are aiming for early this week. I plan to issue an update in to issue #6442 when it is. |
|
Hi Ryan,
Thank you. Please keep us posted
Best,
…On Sun, Feb 9, 2020 at 10:04 PM ryanml ***@***.***> wrote:
Hey @btommm <https://github.com/btommm> - this update actually has not
been released to the browser, we are aiming for early this week. I plan to
issue an update in to issue #6442 when it is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#114?email_source=notifications&email_token=AOQMLHUIOWWXREHWYLWHOSTRCDU5BA5CNFSM4KPMDZQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHKWXQ#issuecomment-583969630>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQMLHU6DCBYDUWCPLWTMV3RCDU5BANCNFSM4KPMDZQA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#6442
Issue here was that given our modified onboarding flow, it was possible to initialize vaults/account without setting the
completedOnboardingflag. This checks for an initialized account without a completed onboarding and sets it so. This will back fix any users who have experienced this issue.Container needed to be overwritten to merge in extra props