Always build HTTPSE with the latest rulesets, fix #7 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschanaj
changed the title
added 2 commits
January 15, 2019 22:59
diracdeltas
reviewed
Jan 18, 2019
| throw err | ||
| } else { | ||
| let timestamp = '' | ||
| let baseURL = 'https://www.https-rulesets.org/v1/' |
There was a problem hiding this comment.
does EFF guarantee that the rulesets published under v1 will be compatible with HTTPSE'2018.9.19' ? i assume so but just checking because they've done a few updates in the past where the format has changed (and so auto-updating would have broken Brave).
otherwise this approach looks great
There was a problem hiding this comment.
The v1 directory was added as per EFForg/https-everywhere#14907 (comment) and EFForg/https-everywhere#14907 (comment), so I assume there shouldn't be breaking changes in the rulesets format. Maybe @Hainish @zoracon from EFF can help guarantee that?
diracdeltas
approved these changes
Jan 18, 2019
|
@bsclifton when you get a chance, please merge this and upload the new HTTPS Everywhere rulesets. Thanks |
fmarier
added a commit
to fmarier/https-everywhere-builder
that referenced
this pull request
Jan 24, 2019
There is no need to bump the XPI version number anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.