This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Fix missing add observer for password store observer #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required by brave/browser-laptop#9085 Auditors: @bridiver, @bbondy
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Jun 8, 2017
fix #8906 resolve item 1 of #8874 requires brave/muon#209 Auditors: @diracdeltas, @bridiver Test Plan: 1. Makue sure you have passwords and never saved sites in about:passwords 2. delete any of them or clear all passwords should relfect changes instantly
7 tasks
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Jun 8, 2017
fix #8906 resolve item 1 of #8874 requires brave/muon#209 Auditors: @diracdeltas, @bridiver Test Plan: 1. Makue sure you have passwords and never saved sites in about:passwords 2. delete any of them or clear all passwords should relfect changes instantly
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Jun 10, 2017
fix #8906 resolve item 1 of #8874 requires brave/muon#209 Auditors: @diracdeltas, @bridiver Test Plan: 1. Makue sure you have passwords and never saved sites in about:passwords 2. delete any of them or clear all passwords should relfect changes instantly
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Jun 10, 2017
fix #8906 resolve item 1 of #8874 requires brave/muon#209 Auditors: @diracdeltas, @bridiver Test Plan: 1. Makue sure you have passwords and never saved sites in about:passwords 2. delete any of them or clear all passwords should relfect changes instantly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required by brave/browser-laptop#9085
Auditors: @bridiver, @bbondy