This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
Compaction API #350
Merged
Compaction API #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Oct 21, 2019
client/requestUtil.js
Outdated
| this.withRetry(() => { | ||
| return s3Helper.listObjects(this.s3, options, false) | ||
| }).then((s3Objects) => { | ||
| let latestRecords = {} |
There was a problem hiding this comment.
this is going to keep the most recent record in each batch, which is fine, but I think we should add a comment to make that clear
32 tasks
darkdh
dismissed stale reviews from SergeyZhukovsky and AlexeyBarabash
via
65e0165
darkdh
force-pushed
the
compaction
branch
3 times, most recently
from
bd636b1
to
3669788
Compare
compaction for up to 100 records Add LRU cache(50 records) for missing part for decryption so it can be decrypted in future round
bridiver
approved these changes
Oct 28, 2019
This was referenced Oct 28, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #341
fix #289
brave/brave-browser#6552 will use this API to initiate the compaction