Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup configurations #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

luizgabrielsilva
Copy link

Modifications

  • Add pyproject.toml and remove setup.py (PyPA specifications);
  • Update dependencies;
  • Update references to the package inside the modules
  • Remove lazy imports from tests and implement general style corrections (flake8)

Notes:

  • Code inside core modules were not modified;
  • There are two tests currently failing (apparently not due to the updates);
  • Two test functions were commented because they were redefining previous test functions;
  • Notebook TimeMetrics in the folder example contains depends on a package not installed during setup (stac). It is in the dependency tree.

@andersonreisoares
Copy link
Collaborator

Looks, good for me. Thank you, @luizgabrielsilva !

@andersonreisoares
Copy link
Collaborator

@raphaelrpl , @marujore I'm not able to accept this pull request. The changes looks ok for me. It any of you have the privileges to merge, I'm ok.

This request closes #15

@marujore
Copy link
Collaborator

@raphaelrpl , @marujore I'm not able to accept this pull request. The changes looks ok for me. It any of you have the privileges to merge, I'm ok.

This request closes #15

@andersonreisoares Sorry about that. Your previleges have been updated, please test it now.

Copy link
Collaborator

@andersonreisoares andersonreisoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luizgabrielsilva , once the requested change is made the pull request will be approved

pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants