Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP domain. #351

Merged
merged 3 commits into from
May 16, 2018
Merged

Add PHP domain. #351

merged 3 commits into from
May 16, 2018

Conversation

pczerkas
Copy link
Contributor

Hello,

this pull request tries to add support for Sphinx PHP domain, using sphinxcontrib-phpdomain==0.2.5 package (when available).

Regards,
Przemek Czerkas

@vermeeren vermeeren self-assigned this May 16, 2018
@vermeeren
Copy link
Collaborator

Sorry for the delay. The changes look good, especially making it all optional. I couldn't find a quick test project for PHP, but current functionality isn't changed. Possible edge cases are future issues, this is a good start.

If you ever have some time feel free to submit some test cases, thank you.

@vermeeren vermeeren merged commit dc3778c into breathe-doc:master May 16, 2018
@vermeeren vermeeren added enhancement Improvements, additions (also cosmetics) code Source code labels May 21, 2018
vermeeren added a commit that referenced this pull request Jun 4, 2018
@rogerbarton rogerbarton mentioned this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Source code enhancement Improvements, additions (also cosmetics)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants