Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React Native CI issues #835

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix React Native CI issues #835

merged 2 commits into from
Feb 29, 2024

Conversation

dangeross
Copy link
Collaborator

Switch to macos-14 to avoid these issues:

actions/runner-images#2322
actions/runner-images#4020

Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/db6a7027cff95a641d6d0c07e00f7b8fa26b0733b6d215c3752b745a381ebcb8--python@3.12-3.12.2_1.bottle_manifest.json
==> Pouring [email protected]_1.monterey.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite [email protected]

To list all files that would be deleted:
  brew link --overwrite [email protected] --dry-run

Possible conflicting files are:
/usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3
/usr/local/bin/2to3-3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3-3.12
/usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3
/usr/local/bin/idle3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3.12
/usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3
/usr/local/bin/pydoc3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3.12
/usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3
/usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3-config
/usr/local/bin/python3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
/usr/local/bin/python3.12-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12-config
/usr/local/share/man/man1/python3.1 -> /usr/local/Cellar/[email protected]/3.11.7_1/share/man/man1/python3.1
/usr/local/lib/pkgconfig/python3-embed.pc -> /usr/local/Cellar/[email protected]/3.11.7_1/lib/pkgconfig/python3-embed.pc
/usr/local/lib/pkgconfig/python3.pc -> /usr/local/Cellar/[email protected]/3.11.7_1/lib/pkgconfig/python3.pc
/usr/local/Frameworks/Python.framework/Headers -> /usr/local/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Headers
/usr/local/Frameworks/Python.framework/Python -> /usr/local/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Python
/usr/local/Frameworks/Python.framework/Resources -> /usr/local/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Resources
/usr/local/Frameworks/Python.framework/Versions/Current -> /usr/local/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Versions/Current

Output:
https://github.com/breez/breez-sdk/actions/runs/8096592794/job/22125677589

@JssDWt
Copy link
Contributor

JssDWt commented Feb 29, 2024

@dangeross did you try removing the brew update instead?

@dangeross
Copy link
Collaborator Author

dangeross commented Feb 29, 2024

@dangeross did you try removing the brew update instead?

Seems to work, but ktlint is then stuck on 1.1.1 (for now). What do you reckon?

https://github.com/breez/breez-sdk/actions/runs/8096893063/job/22126659809

@JssDWt
Copy link
Contributor

JssDWt commented Feb 29, 2024

@dangeross I think this is all just very annoying. I don't see any proper fix. Let's just go for the green checkmark with macos-14. And see it break again later.

@dangeross
Copy link
Collaborator Author

@dangeross I think this is all just very annoying. I don't see any proper fix. Let's just go for the green checkmark with macos-14. And see it break again later.

Very annoying indeed. Ready for review.

@dangeross dangeross merged commit 77f0b65 into main Feb 29, 2024
10 of 14 checks passed
@dangeross dangeross deleted the savage-ci-rn-fix branch February 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants