Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag #9

Closed
2 tasks done
Antonboom opened this issue Mar 12, 2023 · 1 comment · Fixed by #10
Closed
2 tasks done

Bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag #9

Antonboom opened this issue Mar 12, 2023 · 1 comment · Fixed by #10

Comments

@Antonboom
Copy link

Antonboom commented Mar 12, 2023 •
edited
Loading

Hi 🙂

Please, bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag in your repo.

It's important to be consistent with new Go 1.20 golangci-lint.
Related to golangci/golangci-lint#3086

Thanks!

P.S. Optionally I recommend

  • to move linter to 1.20 totally (go.mod, CI, etc.)
  • add support of dependabot
breml added a commit that referenced this issue Mar 12, 2023
@breml
Update to Go 1.19 and golang.org/x/tools v0.7.0
987102b 
Fixes #9
@breml breml mentioned this issue Mar 12, 2023
Merged
breml added a commit that referenced this issue Mar 12, 2023
@breml
Update to Go 1.19 and golang.org/x/tools v0.7.0
2ca26a9 
Fixes #9
@breml breml closed this as completed in #10 Mar 12, 2023
@Antonboom
Copy link
Author

Thank u for attention 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Go 1.19 and golang.org/x/tools v0.7.0 breml/bidichk
1 participant
@Antonboom