Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change analyzer doc #27

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Change analyzer doc #27

merged 1 commit into from
Nov 20, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 20, 2023 •
edited
Loading

This PR changes the analyzer description to remove duplicated bidichk word:

Before:

❯ go run cmd/bidichk/main.go
bidichk: bidichk detects dangerous unicode character sequences

After:

❯ go run cmd/bidichk/main.go
bidichk: Checks for dangerous unicode character sequences

Also, after this PR is merged we can refactor the golangci-lint code to the following:

	return goanalysis.NewLinter(
		a.Name,
		a.Doc,
		[]*analysis.Analyzer{a},
		cfgMap,
	).WithLoadMode(goanalysis.LoadModeSyntax)

@alexandear alexandear changed the title Change analyzer doc to match golangci-lint's description Change analyzer doc Nov 20, 2023
breml
breml approved these changes Nov 20, 2023
View reviewed changes
Copy link
Owner

@breml breml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breml breml merged commit 446f500 into breml:master Nov 20, 2023
10 checks passed
@alexandear alexandear deleted the change-doc branch November 20, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breml breml breml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @breml