Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte should be base64Url encoded ByteString not Word8 #26

Closed
amarpotghan opened this issue Jun 4, 2016 · 4 comments
Closed

Byte should be base64Url encoded ByteString not Word8 #26

amarpotghan opened this issue Jun 4, 2016 · 4 comments
Assignees
Labels

Comments

@amarpotghan
Copy link

amarpotghan commented Jun 4, 2016

First of all thanks for your excellent work. I noticed this problem while I was trying to use gmail-api. mraw should be base64Url encoded ByteString instead of a Word8. Google description here: https://developers.google.com/discovery/v1/type-format . I think other gogol-* libraries affected as well by this.

@brendanhay brendanhay added the bug label Jun 4, 2016
@brendanhay brendanhay self-assigned this Jun 4, 2016
@brendanhay
Copy link
Owner

brendanhay commented Jun 4, 2016

Thanks for raising the issue, it effects multiple libraries as you mention. I'll look into it!

@amarpotghan
Copy link
Author

Thank you for quick response :)

@MaxDaten
Copy link

-- | Image content, represented as a stream of bytes.
gogol-vision Network.Google.Vision.iContent :: Lens' Image (Maybe Word8)

-- | Image content, represented as a stream of bytes.

is also affected

@brendanhay
Copy link
Owner

The generation code has been updated to select a new internal representation for bytes types. This representation now handles transparent encoding/decoding of Base64URL encoding, and changes the external lens interface to accept a plain (unencoded) ByteString. See PR #29 for specifics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants