Transparently handle Base64 encoding #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally a Base64 wrapper to signal encoding is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external lens interface for fields that were previously of type
bytes :: [Word8]now allows the user to exclusively pass/retrieve an unencodedByteStringwhich is then wrapped in aBase64newtype internally, to ensure the correct Base64URL encoding occurs.For any list-like occurences, _Coerce is used identically to other wrapped internal isos - assumed to be zero-cost.
This fixes issue #26, with the signatures of lenses changing from:
To the new interface which you pass unencoded data: