Avoid deprecated servant import. It was removed in 0.17 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
S/LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servant.Utils.Linkswas deprecated inservant14.1 - haskell-servant/servant#998It has now been removed entirely in
servant0.17, which breaksgogol-corefrom building. Switching to the non-deprecated module path fixes it.This does mean that
gogol-corewill not build on older thanservant14.1. However 14.1 was released 6 Jul 2018, so I'm hoping that is ok?Hmm..
ghc 8.6.4 -
lts-13.19usesservant0.15 ✔️ghc 8.4.4 -
lts-12.26usesservant0.14.1 ✔️ghc 8.2.2 -
lts-11.22usesservant0.13 🙅♂️So I guess as is this would require dropping ghc 8.2.2 support..