Don't dispatch on VectorizationBase.Vec
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
nanminandnanmaxdispatched onVectorizationBase.Vec{N, <:AbstractFloat}which was a convenient way to avoid unnecessary comparisons on arrays which didn't containAbstractFloatand couldn't containNaNs.However, at some point LoopVectorization.jl / VectorizationBase.jl appears to have started also (?) emitting a more complicated
VectorizationBase.VecUnrollwhich hit the untyped fallback method innanmin/nanmaxwhich gave incorrect results.To avoid that problem, this fix for now just treats everything as if it potentially contains
NaNs, and makes no assumptions about the internals of LoopVectorzation / VectorizationBase so should be more robust to future changes at the minor cost of being a bit slower for arrays of integers.Should test and fix #19