Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Julia v1.9 @turbo empty iterator error of quickselect!, #35 #36

Merged
merged 4 commits into from
May 11, 2023

Conversation

kongdd
Copy link
Contributor

@kongdd kongdd commented May 11, 2023

This is a temporal solution for #35.
If @turbo can accept empty iterator, this issue will be gone.

See details in #LoopVectorization.jl/#492

@brenhinkeller brenhinkeller merged commit e6b828b into brenhinkeller:main May 11, 2023
@brenhinkeller
Copy link
Owner

Thanks for the PR!

Static = "0.2 - 0.8"
julia = "1.8"
Static = "0.8"
julia = "1.8, 1.9"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for future reference, just "1.8" allows everything in the 1.x series greater than 1.8 (since after 1.0, minor version numbers aren't breaking any more)

@turbo
Copy link

turbo commented May 11, 2023

Please keep in mind that @ pings the respective GitHub user and consider using inline code in comments and commits to avoid this.

@brenhinkeller
Copy link
Owner

Sorry turbo! I wonder if there's a way to mute all mentions from a particular language..

@kongdd
Copy link
Contributor Author

kongdd commented May 12, 2023

Please keep in mind that @ pings the respective GitHub user and consider using inline code in comments and commits to avoid this.

Sorry turbo. It is my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants