Merge with master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt` if unset for auto-scaled
…esCluster_autoScalingNodeCountUnset
…esCluster_legacyAgentPoolProfileVMSS
TestAccAzureRMKubernetesCluster_enableNodePublicIP - ForceNew for a PublicIP TestAccAzureRMKubernetesCluster_windowsProfile - username is forcenew
Also adding a new test to confirm removing a node pool
Documentation Fixes
refactor: moving clients A -> C
r/nat_gateway: handling a crash when the `sku` block is nil
This was a fun one to track down. Turns out due to the way that parallelization works, `init()` gets called after the `resource.ParallelTest` has been called - which means that `testAccProviders` could be an empty slice, which caused an unhelpful crash in the Plugin SDK.
refactor: making correlation id private
refactor: removing usages of deprecated packages
provider: ensuring the providers slice isn't a nil pointer
…torage_accounts Bug: List storage accounts returns only first page
Custom Timeouts: adding compile-time checks
…rennerm/terraform-provider-azurerm into brennerm-add-app-configuration-resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.