Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare #1923

Merged
merged 4 commits into from
Jul 16, 2019
Merged

Fix compare #1923

merged 4 commits into from
Jul 16, 2019

Conversation

brianc
Copy link
Owner

@brianc brianc commented Jul 16, 2019

deepEqual doesn't compare buffer and an array in node v12.

In node 12 assert.deepEqual against a buffer & array no longer passes if the values are the same.  This makes sense.  Updated the test to not use deepEqual in this case.
@brianc brianc merged commit 0acaf9d into master Jul 16, 2019
@brianc brianc deleted the bmc/fix-compare branch July 16, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant