[pg-stream] Async iterable #2050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Does not emit `error` [events](https://nodejs.org/api/stream.html#stream_errors_while_reading) - Properly destroy the stream in case of error while reading - Does not emit `close` to aclively close. `close` avents should be used to notify that the stream *was* closed, and not that the stream must be closed. - No need to keep a custom `this.batchSize`. The internal Readable machinery relies on a `highWaterMark` that does exactly that when reading more rows. - No need to make an additional `cursor.read()` when we received fewer rows than requested (the cursor will always return exactly the requested number of rows, unless there are no more rows to be read from the query).
brianc
added a commit
that referenced
this pull request
Dec 28, 2019
There were some subtle behaviors with the stream being implemented incorrectly & not working as expected with async iteration. I've modified the code based on #2050 and comments in #2035 to have better test coverage of async iterables and update the internals significantly to more closely match the readable stream interface. Note: this is a __breaking__ (semver major) change to this package as the close event behavior is changed slightly, and `highWaterMark` is no longer supported. It shouldn't impact most usage, but breaking regardless.
brianc
added a commit
that referenced
this pull request
Dec 30, 2019
* Fix pg-query-stream There were some subtle behaviors with the stream being implemented incorrectly & not working as expected with async iteration. I've modified the code based on #2050 and comments in #2035 to have better test coverage of async iterables and update the internals significantly to more closely match the readable stream interface. Note: this is a __breaking__ (semver major) change to this package as the close event behavior is changed slightly, and `highWaterMark` is no longer supported. It shouldn't impact most usage, but breaking regardless. * Remove a bunch of additional code * Add test for destroy + error propagation * Add failing test for destroying unsubmitted stream * Do not throw an uncatchable error when closing an unused cursor
|
Fixed by #2051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erroreventscloseto aclively close.closeavents should be used to notify that the stream was closed, and not that the stream must be closed.this.batchSize. The internal Readable machinery relies on ahighWaterMarkthat does exactly that when reading more rows.cursor.read()when we received fewer rows than requested (the cursor will always return exactly the requested number of rows, unless there are no more rows to be read from the query).