Remove password from stringified outputs

[brianc]

There's a security concern where if you're not careful and you include your client or pool instance in console.log or stack traces it might include the database password. To widen the pit of success I'm making that field non-enumerable. You can still get at it...it just wont show up "by accident" when you're logging things now.

The backwards compatibility impact of this is very small, but it is still technically somewhat an API change so...8.0.

closes #2064 #1568

[charmander]

I think

let password = …
Object.defineProperty(…, 'password', {
  enumerable: false,
  configurable: false,
  get() {
    return password
  },
  set(value) {
    password = value
  }
})

should be written as

Object.defineProperty(…, 'password', {
  configurable: true,
  enumerable: false,
  writable: true,
  value: password,
})

It might also be helpful for diffing purposes if the formatting changes are put directly into the base branch.

[brianc]

Yeah...the formatting is kinda jacked as pg-pool, pg-cursor, and pg all had different lint rules...so my vscode autoformatting went a bit crazy. I temporarily turned it off for this repo. I want to do a single big "prettier + eslint reformat everything all at once" commit & then clamp down on 1 set of lint rules + prettier for the whole repo, but waiting until after 8.0 just so if anyone wants to bisect what changed between the releases there's less noise in the diff.

[charmander]

Made a pull request to this pull request at #2070. If this branch has the changes from #2071 added to it, tests will start failing; that’s fixed in faa0f38. I’ve left that merge out of the pull request to keep managing history simple, so it can be rebase-merged onto this one.

[brianc]

rebase-merged onto this one.

sorry i missed that - i did a sqash merge (was planning on doing a squash merge of this into bmc/8.0)