-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): pg-query-stream typescript #2376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks rad - lmk if you have any questions!
"module": "commonjs", | ||
"esModuleInterop": true, | ||
"allowSyntheticDefaultImports": true, | ||
"strict": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be nice to turn this to true
one day, but this is fine for the initial port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be possible after pg-cursor is converted. I will look at pg-cursor next
I think this should be ready to review.
|
const { batchSize, highWaterMark = 100 } = config | ||
// https://nodejs.org/api/stream.html#stream_new_stream_readable_options | ||
super({ objectMode: true, emitClose: true, autoDestroy: true, highWaterMark: batchSize || highWaterMark }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: why remove emitClose
here?
This looks solid - thanks a lot for doing this! Sorry for the delay....have had a really horrible October - my doggie died. 😭 back in the saddle again now though. |
emitClose is true by default and typescript was throwing error when It was trying to pass this option. |
Sorry to hear about your dog. |
@chyzwar sorry for the delay...life is crazy. I'm down to merge this but there are a few merge conflicts. Care to take a quick look at those & resolve them? Then i'll get this merged! Thanks again! ❤️ |
886de1e
to
76a5316
Compare
this now has been rebased on master. |
awesome! thanks! Will get this merged up today! |
release [email protected] |
Added issue #2412 |
New version should emit types compatible with
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/47e9cf6d8947e46a82bb09bbcc3dd74a3ac0ffa1/types/pg-query-stream/index.d.ts
Let me know if this is going to right direction?
TODO: