pg: Re-export DatabaseError from 'pg-protocol' #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakoose
force-pushed
the
reexport-databaseerror
branch
2 times, most recently
from
dbfd1cf
to
7a649d3
Compare
Before, users would have to import DatabaseError from 'pg-protocol'. If there are multiple versions of 'pg-protocol', you might end up using the wrong one. Closes brianc#2378
cakoose
force-pushed
the
reexport-databaseerror
branch
from
7a649d3
to
b3dc879
Compare
|
@cakoose I'm not sure how you consume it? Since pg is not a Typescript project, there's no types associated to |
|
Thanks for the reminder! Just opened a PR for "@types/pg": DefinitelyTyped/DefinitelyTyped#52804 (I had to wait until this landed before opening the PR on DefinitelyTyped. The last attempt opened the PR too early: DefinitelyTyped/DefinitelyTyped#49188) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, users would have to import DatabaseError from 'pg-protocol'. If
there are multiple versions of 'pg-protocol', you might end up using the
wrong one.
Closes #2378