Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Cursor into an ES6 class #2553

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Conversation

Bluenix2
Copy link
Contributor

Unlike most other objects Cursor has remained unchanged to an ES6 class. As somewhat expected the git diff is kind of a mess when changes like these happen, I don't think there's anything that can be done considering everything had to be indented an additional time.

packages/pg-cursor/index.js Outdated Show resolved Hide resolved
@charmander charmander added this to the [email protected] milestone May 28, 2021
packages/pg-cursor/index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@charmander charmander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brianc
Copy link
Owner

brianc commented Jun 22, 2021

Sorry for the delay here - really appreciate this! Merging now. You marked this as a breaking change but none of the tests needed to change - is this a semver major thing? I'm fine either way & can release it however you think is best.

@brianc brianc merged commit a040031 into brianc:master Jun 22, 2021
@Bluenix2
Copy link
Contributor Author

You marked this as a breaking change but none of the tests needed to change - is this a semver major thing? I'm fine either way & can release it however you think is best.

Did I? This shouldn't be breaking yes.

@Bluenix2 Bluenix2 deleted the Cursor-es6-class branch June 22, 2021 18:41
Bluenix2 added a commit to Bluenix2/node-postgres that referenced this pull request Jun 22, 2021
* Turn Cursor into an ES6 class

* Fix incorrect syntax in Cursor.end()

* Remove extraneous empty line

* Revert es6 change for end()

* Revert back to defining the end() method inside the class

* Use hanging indent to satisfy Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants