use crypto.pbkdf2Sync in sasl auth #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmander
approved these changes
Sep 17, 2022
brianc
approved these changes
Sep 17, 2022
There was a problem hiding this comment.
This is great - thanks for diving in here! Really appreciate the community attention on the parts of the library my venture doesn't use on a day to day basis. I need to make a note to myself to eventually convert this function to async as doing anything with *Sync in the name is probably not as good long term as using the async version....though connections to postgres are already rather slow (due to the protocol and handshake itself) and not extremely common (and the previous code was blocking) so I'm not immediately highly concerned.
|
@brianc hi, when do you plan to release a new version of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2814