Set database on socket string connection #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to conect to a specific database trough this ways:
pg.connect('/some/path database', callback);
pg.connect('socket:/some/path?db=database', callback)
pg.connect('socket:/some/path?db=database&encoding=utf8', callback)
|
PS: i'm using this modification to have the same js code connecting on heroku pg and on my local system pg, using a socket string from env var, with a specific db name on my local system. |
|
TODO: after merge, may be good to add information on |
| @@ -47,10 +47,44 @@ test('ConnectionParameters initializing from config', function() { | |||
| assert.ok(subject.isDomainSocket === false); | |||
| }); | |||
|
|
|||
| test('escape spaces if present', function() { | |||
| subject = new ConnectionParameters('postgres://localhost/post gres'); | |||
|
This is a great pull request. If you have anything else you'd like to add or change, please feel free. 😄 👍 thank you so much! 🙆♀️ Going to run my local test suite, merge it, document the change in the changelog, and bump the minor version. |
brianc
added a commit
that referenced
this pull request
Dec 20, 2013
Set database on socket string connection
|
Nice! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to connect to a specific database trough this ways:
Closes issue 484