Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix c warnings #204

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Fix c warnings #204

merged 3 commits into from
Jun 24, 2021

Conversation

eileencodes
Copy link
Collaborator

Fix implicit conversion from enumeration type warning
yajl_gen_error is a yajl_gen_state not a yajl_gen_status.
This change adds a new value to the enum for an error when the
decremented depth is too low.

Warnings:

../../../../ext/yajl/yajl_gen.c:295:5: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status'
      [-Wenum-conversion]
    DECREMENT_DEPTH;
    ^~~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:181:48: note: expanded from macro 'DECREMENT_DEPTH'
    if (--(g->depth) >= YAJL_MAX_DEPTH) return yajl_gen_error;
                                        ~~~~~~ ^~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:321:5: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status'
      [-Wenum-conversion]
    DECREMENT_DEPTH;
    ^~~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:181:48: note: expanded from macro 'DECREMENT_DEPTH'
    if (--(g->depth) >= YAJL_MAX_DEPTH) return yajl_gen_error;
                                        ~~~~~~ ^~~~~~~~~~~~~~

Fix missing switch case
yajl_tok_comment was not present in the switch case.

Warnings:

compiling ../../../../ext/yajl/yajl_lex.c
../../../../ext/yajl/yajl_lex.c:42:13: warning: enumeration value 'yajl_tok_comment' not handled in switch [-Wswitch]
    switch (tok) {
            ^
../../../../ext/yajl/yajl_lex.c:42:13: note: add missing switch cases
    switch (tok) {
            ^

eileencodes and others added 2 commits June 24, 2021 16:35
`yajl_gen_error` is a `yajl_gen_state` not a `yajl_gen_status`.
This change adds a new value to the enum for an error when the
decremented depth is too low.

Warnings:

```
../../../../ext/yajl/yajl_gen.c:295:5: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status'
      [-Wenum-conversion]
    DECREMENT_DEPTH;
    ^~~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:181:48: note: expanded from macro 'DECREMENT_DEPTH'
    if (--(g->depth) >= YAJL_MAX_DEPTH) return yajl_gen_error;
                                        ~~~~~~ ^~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:321:5: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status'
      [-Wenum-conversion]
    DECREMENT_DEPTH;
    ^~~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:181:48: note: expanded from macro 'DECREMENT_DEPTH'
    if (--(g->depth) >= YAJL_MAX_DEPTH) return yajl_gen_error;
                                        ~~~~~~ ^~~~~~~~~~~~~~
```

Co-authored-by: John Hawthorn <[email protected]>
`yajl_tok_comment` was not present in the switch case.

Warnings:

```
compiling ../../../../ext/yajl/yajl_lex.c
../../../../ext/yajl/yajl_lex.c:42:13: warning: enumeration value 'yajl_tok_comment' not handled in switch [-Wswitch]
    switch (tok) {
            ^
../../../../ext/yajl/yajl_lex.c:42:13: note: add missing switch cases
    switch (tok) {
            ^
```

Co-authored-by: John Hawthorn <[email protected]>
@brianmario brianmario merged commit 7168bd7 into brianmario:master Jun 24, 2021
@eileencodes eileencodes deleted the fix-c-warnings branch June 24, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants