Fix doctrine orm carbon type #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think here we could simply use parse instead. Does the following work fine for you with Postgres? $date = $class::parse($value);Instead of the whole ternary expression. This should also ease to change the precision keeping existing data. For the record, I highly recommend to store microseconds precision. This is easy to trim data you don't need but impossible to get the data you didn't store. |
kylekatarnls
requested changes
Mar 26, 2020
When microseconds are set to zero, postgres doesn't use 'Y-m-d H:i:s.u' format but 'Y-m-d H:i:s'.
Flodess
force-pushed
the
fix-doctrine-orm-carbon-type
branch
from
97a58e8
to
ce15089
Compare
kylekatarnls
approved these changes
Mar 26, 2020
|
Thanks, I will publish a patch for that today. |
|
Waouh, that was fast! Thx :) |
|
2.32.1 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When I tried the new carbon type, I got a "Data missing".
This is due to postgres not using the 'Y-m-d H:i:s.u' format but 'Y-m-d H:i:s' when microseconds are set to zero.
The solution is based on this comment :
doctrine/dbal#2873 (comment)