Fix issue with Symfony\Translate v4.4.27 #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue introduced by Symfony\Translate v4.4.27 changing the default return value of `getLocale()` to fallback to `\Locale::getDefault()` when php-intl is installed and enabled; and `'en'` when it is not. Previously, a newly initialized `Translator` object would have returned `null` from `getLocale()` on first initialization, which would have made this check pass. However, this change now means that the initialization that is supposed to occur from a fresh Translator calling setLocale() on itself will fail under the following conditions: - The locale being initialized matches the one returned by `\Locale::getDefault()` on systems with php-intl installed and enabled - Or the locale being initialized is `en` on systems where php-intl is not installed or enabled. See symfony/translation@c1cca3e#commitcomment-54056868, wintercms/winter#256, and octobercms/library@ff2cec6 for more information on affected projects.
|
@kylekatarnls if you could review this ASAP that would be greatly appreciated, this is breaking all @wintercms projects that attempt to update to the newest Symfony\Translate. |
|
No problem @kylekatarnls, thanks for all your hard work on this absolutely essential piece of the PHP development scene for so many years! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced by Symfony\Translate v4.4.27 changing the default return value of
getLocale()to fallback to\Locale::getDefault()when php-intl is installed and enabled; and'en'when it is not.Previously, a newly initialized
Translatorobject would have returnednullfromgetLocale()on first initialization, which would have made this check pass. However, this change now means that the initialization that is supposed to occur from a fresh Translator calling setLocale() on itself will fail under the following conditions:\Locale::getDefault()on systems with php-intl installed and enabledenon systems where php-intl is not installed or enabled.See symfony/translation@c1cca3e#commitcomment-54056868, wintercms/winter#256, and octobercms/library@ff2cec6 for more information on affected projects.