Use small Curve25519 for wasm32 & other non-{aarch64,x86_64}. #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable `ring::agreement` for wasm32 targets using the small implementation of Curve25519. Use the small Curve25519 implementation of Curve25519 (and P-256) for all targets except for Aarch64 and x86-64. Besides being smaller, the small implementations are likely more resistant to compiler-introduced side-channels, which is especially important for the wasm32 virtual machine and other targets that we don't QA as thoroughly as AAarch64 and x86-64. Bring in the previously-removed definition of `fe_mul_llt` from BoringSSL as of commit 8d71d24.
Codecov Report
@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
- Coverage 96.10% 96.09% -0.01%
==========================================
Files 137 137
Lines 20548 20607 +59
Branches 217 221 +4
==========================================
+ Hits 19747 19802 +55
- Misses 762 766 +4
Partials 39 39
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
ring::agreementfor wasm32 targets using the small implementation of Curve25519.Use the small Curve25519 implementation of Curve25519 (and P-256) for all targets except for Aarch64 and x86-64.
Besides being smaller, the small implementations are likely more resistant to compiler-introduced side-channels, which is especially important for the wasm32 virtual machine and other targets that we don't QA as thoroughly as AAarch64 and x86-64.
Bring in the previously-removed definition of
fe_mul_lltfrom BoringSSL as of commit8d71d24.