New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Android targeting API 26 and test with API 24 system image. #777

Merged

briansmith merged 1 commit into briansmith:master from pietro:test_android

Jan 31, 2019

Contributor

pietro commented Jan 30, 2019

Fixes #603 and we can also close #473 even though the switch to clang didn't happen in this pr.


          Build Android targeting API 26 and test with API 24 system image.

072c947

Testing with API 24 images because there are no API 26 ARM images available.

I agree to license my contributions to each file under the terms given
at the top of each file I changed.

coveralls commented Jan 30, 2019

Coverage decreased (-0.004%) to 93.61% when pulling 072c947 on pietro:test_android into c7f0ead on briansmith:master.

4 similar comments

coveralls commented Jan 30, 2019

Coverage decreased (-0.004%) to 93.61% when pulling 072c947 on pietro:test_android into c7f0ead on briansmith:master.

coveralls commented Jan 30, 2019

Coverage decreased (-0.004%) to 93.61% when pulling 072c947 on pietro:test_android into c7f0ead on briansmith:master.

coveralls commented Jan 30, 2019

Coverage decreased (-0.004%) to 93.61% when pulling 072c947 on pietro:test_android into c7f0ead on briansmith:master.

coveralls commented Jan 30, 2019

Coverage decreased (-0.004%) to 93.61% when pulling 072c947 on pietro:test_android into c7f0ead on briansmith:master.

coveralls commented Jan 30, 2019 •

edited

Loading

Coverage decreased (-0.002%) to 93.613% when pulling 072c947 on pietro:test_android into c7f0ead on briansmith:master.

Contributor Author

pietro commented Jan 30, 2019

@briansmith I need to look into being able to update the sdk tools and systems images. I won't have much time in the next few weeks though. Can you delete the caches for ring on travis and re-run the build?

Owner

briansmith commented Jan 31, 2019

Thanks!

Can you delete the caches for ring on travis and re-run the build?

I just did this.

briansmith reviewed

View reviewed changes

README.md Show resolved Hide resolved

briansmith merged commit 49ec480 into briansmith:master

Owner

briansmith commented Jan 31, 2019

Thanks! This was merged as 49ec480. I clarified some of the documentation in 5c8c13e and 88d3279; this included fixing the typo I mentioned above.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet